Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce substeps for rex pull mode based on yggdrasil version #3492

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

asteflova
Copy link
Member

@asteflova asteflova commented Dec 4, 2024

What changes are you introducing?

Updating documentation on configuring Rex in pull mode, introducing substeps based on which version of yggdrasil is available on the host.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

theforeman/foreman-packaging#11317

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Draft because I still need to cover:

* theforeman/foreman-packaging#11317 (comment)
* Add a new prerequisite to enable Appstream to the procedure for registering hosts/rex pull client.

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • We do not accept PRs for Foreman older than 3.7.

@asteflova asteflova force-pushed the SAT-27476_yggdrasil branch from f040955 to 70106ea Compare December 5, 2024 18:50
@asteflova asteflova marked this pull request as ready for review December 6, 2024 14:33
@asteflova asteflova added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Dec 6, 2024
@asteflova asteflova force-pushed the SAT-27476_yggdrasil branch 2 times, most recently from 324b067 to 1e28f00 Compare December 6, 2024 17:56
@asteflova
Copy link
Member Author

@adamruzicka acked the changes. However, I will split off the troubleshooting section into a separate PR.

@asteflova asteflova added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Dec 10, 2024
@asteflova
Copy link
Member Author

I moved the troubleshooting part to #3516.

@asteflova
Copy link
Member Author

@maximiliankolb I believe I've implemented your feedback, is there anything else? If not, can I consider this style-acked?

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM style-wise.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Dec 11, 2024
@asteflova asteflova merged commit a7e8794 into theforeman:master Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants