-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce substeps for rex pull mode based on yggdrasil version #3492
Conversation
The PR preview for 08badbd is available at theforeman-foreman-documentation-preview-pr-3492.surge.sh The following output files are affected by this PR:
|
f040955
to
70106ea
Compare
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_troubleshooting-remote-jobs-timing-out-after-yggdrasil-update.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_configuring-a-host-to-use-the-pull-client.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_troubleshooting-remote-jobs-timing-out-after-yggdrasil-update.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_troubleshooting-remote-jobs-timing-out-after-yggdrasil-update.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_troubleshooting-remote-jobs-timing-out-after-yggdrasil-update.adoc
Outdated
Show resolved
Hide resolved
324b067
to
1e28f00
Compare
@adamruzicka acked the changes. However, I will split off the troubleshooting section into a separate PR. |
3be98ac
to
08badbd
Compare
I moved the troubleshooting part to #3516. |
@maximiliankolb I believe I've implemented your feedback, is there anything else? If not, can I consider this style-acked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, LGTM style-wise.
What changes are you introducing?
Updating documentation on configuring Rex in pull mode, introducing substeps based on which version of yggdrasil is available on the host.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
theforeman/foreman-packaging#11317
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Draft because I still need to cover:* theforeman/foreman-packaging#11317 (comment)* Add a new prerequisite to enable Appstream to the procedure for registering hosts/rex pull client.Checklists
Please cherry-pick my commits into: