Use newer container naming in container BATS

[ianballou]

Since container repos now have slashes in them, the test needs updating.

I also updated the version requirement for the container push test since it should run on Katello 4.14. (It still needs investigation though :) )

I haven't been able to actually test this yet due to issues running the pipeline locally.

[ekohl]

Instead of adding a new test, should we guard this variable behind a version check? Something like

Suggested change

	CONTAINER_PULL_LABEL=$(echo "${ORGANIZATION_LABEL}/${PRODUCT_LABEL}/${CONTAINER_REPOSITORY_LABEL}"| tr '[:upper:]' '[:lower:]')
	if tIsVersionNewer "${KATELLO_VERSION}" 4.16
	CONTAINER_PULL_LABEL=$(echo "${ORGANIZATION_LABEL}/${PRODUCT_LABEL}/${CONTAINER_REPOSITORY_LABEL}"| tr '[:upper:]' '[:lower:]')
	else
	CONTAINER_PULL_LABEL=$(echo "${ORGANIZATION_LABEL}-${PRODUCT_LABEL}-${CONTAINER_REPOSITORY_LABEL}"| tr '[:upper:]' '[:lower:]')
	fi

My reasoning is you always only run one or the other. If there was a version where you ran both tests then an additional test is obviously better.

[ianballou]

Sure, that works for me.

[ekohl]

I haven't been able to actually test this yet due to issues running the pipeline locally.

I trust you on it. Do you want to merge this now?

[ianballou]

Merging! It'll be broken tomorrow regardless if we don't merge this, so at least it should get us closer even if there's an issue here.

[ekohl]

I just ran a nightly pipeline and getting a failure:

not ok 9 almalinux9 install: try fetching container content
# (in test file fb-katello-client-global-registration.bats, line 81)
#   `podman pull "${HOSTNAME}/${CONTAINER_PULL_LABEL}"' failed with status 125
# $ [fb-katello-client-global-registration.bats, line 78]
# $ tPackageExists podman
# $$ [os_helper.bash, line 83]
# $$ tIsRedHatCompatible
# $$$ [os_helper.bash, line 4]
# $$$ [[ -f /etc/redhat-release ]]
# $$ [os_helper.bash, line 84]
# $$ rpm -q "$1" > /dev/null
# $ [fb-katello-client-global-registration.bats, line 79]
# $ podman login "${HOSTNAME}" -u admin -p changeme
# Login Succeeded!
# $ CONTAINER_PULL_LABEL=$(echo "${ORGANIZATION_LABEL}-${PRODUCT_LABEL}-${CONTAINER_REPOSITORY_LABEL}"| tr '[:upper:]' '[:lower:]')
# $ echo "${ORGANIZATION_LABEL}-${PRODUCT_LABEL}-${CONTAINER_REPOSITORY_LABEL}"
# $ tr '[:upper:]' '[:lower:]'
# $ podman pull "${HOSTNAME}/${CONTAINER_PULL_LABEL}"
# Trying to pull pipe-katello-server-nightly-almalinux9.example.com/test_organization-test_product-foremanbusybox:latest...
# Error: initializing source docker://pipe-katello-server-nightly-almalinux9.example.com/test_organization-test_product-foremanbusybox:latest: reading manifest latest in pipe-katello-server-nightly-almalinux9.example.com/test_organization-test_product-foremanbusybox: name unknown: test_organization-test_product-foremanbusybox was not found!

Note this is in a different file:

forklift/bats/fb-katello-client-global-registration.bats

Lines 77 to 82 in 518b53b

	@test "try fetching container content" {
	tPackageExists podman || tPackageInstall podman
	podman login "${HOSTNAME}" -u admin -p changeme
	CONTAINER_PULL_LABEL=$(echo "${ORGANIZATION_LABEL}-${PRODUCT_LABEL}-${CONTAINER_REPOSITORY_LABEL}"| tr '[:upper:]' '[:lower:]')
	podman pull "${HOSTNAME}/${CONTAINER_PULL_LABEL}"
	}

But also in the container file it's using dashes, not slashes. I can't quite see what the value of KATELLO_VERSION is.

[ianballou]

We have container tests outside the container test file? Dang... Well I'll need to try it myself, I should be able to get the pipeline running locally if you did.

[ekohl]

We have container tests outside the container test file? Dang...

In the global registration I think it's verifying that it sets up podman auth so you can pull container images.

But note that also the tests you modified don't pass. Really looks like either the version is wrong or the comparison.

Well I'll need to try it myself, I should be able to get the pipeline running locally if you did.

I'll admit I just relied on Jenkins and I only copied the results from there. It's been a while since I ran it locally.

[ianballou]

In the global registration I think it's verifying that it sets up podman auth so you can pull container images.

I think I'll just remove the podman test, we don't have registration automation for setting up container registry authentication (yet :) )

But note that also the tests you modified don't pass. Really looks like either the version is wrong or the comparison.

Yeah, it was just wishful thinking assuming that I'd get those comparisons right the first try. I'm aiming to get it settled today.

[ekohl]

I think I'll just remove the podman test, we don't have registration automation for setting up container registry authentication (yet :) )

I have some vague recollection we set up certificates for podman somewhere so it could pull, but I can't find that now.

[ianballou]

I think I'll just remove the podman test, we don't have registration automation for setting up container registry authentication (yet :) )

I have some vague recollection we set up certificates for podman somewhere so it could pull, but I can't find that now.

I suppose testing that some other system can pull container content is worthwhile. The CA does need to be installed so podman can trust the repo. The tests on the nightly box itself wouldn't catch issues there.