Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packit config #370

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Add packit config #370

merged 1 commit into from
Jun 2, 2023

Conversation

ofedoren
Copy link
Member

No description provided.

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'packages': defaultdict(<class 'dict'>, {'rubygem-hammer_cli': {'value': {'upstream_tag_template': ['Not a valid string.']}}}), 'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'rubygem-hammer_cli': {'value': {'upstream_tag_template': ['Not a valid string.']}}})}}}).

For more info, please check out the documentation or contact the Packit team.

@ofedoren ofedoren force-pushed the add-packit branch 14 times, most recently from cce49a0 to 5b032ae Compare May 29, 2023 13:39
@ofedoren
Copy link
Member Author

/packit build

Comment on lines +21 to +22
- "sed -i '/^%global prereleasesource pre.develop$/d' rubygem-hammer_cli.spec"
- "sed -i '/^%global prerelease %{?prereleasesource:.}%{?prereleasesource}$/d' rubygem-hammer_cli.spec"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the best way, but without that it would try to build hammer-cli-3.8.0.pre.develop.pre.develop. I guess it's due to Version: 3.8.0.pre.develop instead of Version: 3.8.0 in locally pulled rubygem-hammer_cli.spec for some reason.

@evgeni, as a packit guru, can you suggest a better solution or it will do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same problem I had in Katello/katello#10566 and so far I have no elegant solution for that

@ofedoren
Copy link
Member Author

ofedoren commented Jun 2, 2023

Since theforeman/hammer-cli-foreman#615 was merged, I'm merging this one as well (they are pretty similar).

@ofedoren ofedoren merged commit 25b47c4 into theforeman:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants