Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides/BRs not set up correctly for bundle mode #17

Open
domcleal opened this issue Aug 31, 2016 · 4 comments
Open

Provides/BRs not set up correctly for bundle mode #17

domcleal opened this issue Aug 31, 2016 · 4 comments

Comments

@domcleal
Copy link
Contributor

1e5c0c8 removed some provides/BRs that are needed in bundle mode, which disables AutoReq/Prov:

  1. Provides: npm(name) is missing
  2. Requires: nodejs(engine) is missing
  3. BuildRequires: npm is missing
@kasicka
Copy link
Contributor

kasicka commented Sep 1, 2016

nodejs-packaging takes care of these things, so nobody really puts them in the spec file.

@domcleal
Copy link
Contributor Author

domcleal commented Sep 1, 2016

In the bundle strategy the autoreq/prov are disabled as nodejs-packaging would generate false requires and provides for the packages within the bundle, within the package. As long as AutoReq/Prov are disabled, they'd be needed. nodejs-packaging also does not add npm as a BR.

@kasicka
Copy link
Contributor

kasicka commented Sep 1, 2016

nodejs package in fedora from 24 and later bundles npm and has that resolved. I see no reason why you should add npm as BR if the package itself doesn't depend on npm.

@domcleal
Copy link
Contributor Author

domcleal commented Sep 1, 2016

The bundle strategy uses npm to install dependencies into the (bundled) node_modules/ dir during %build, it's a build dependency when using -s bundle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants