Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn off autoSave by default #4777

Merged
merged 1 commit into from
Apr 2, 2019
Merged

turn off autoSave by default #4777

merged 1 commit into from
Apr 2, 2019

Conversation

akosyakov
Copy link
Member

fix #4776

@benoitf
Copy link
Contributor

benoitf commented Apr 2, 2019 •
edited
Loading

this kind of stuff should be included in Changelog (it's as important as a breaking change) (and how OEM users could apply in their package.json an override to change the behavior)

@akosyakov
fix #4776: turn off autoSave by deafult
26d520e 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov
Copy link
Member Author

@benoitf sounds good, CHANGELOG is updated

@akosyakov akosyakov merged commit 9eb7f4e into master Apr 2, 2019
@akosyakov akosyakov deleted the GH-4776 branch April 2, 2019 12:35
@vince-fugnitto vince-fugnitto mentioned this pull request Jun 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn autosave off by default
3 participants
@akosyakov @benoitf @svenefftinge