Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate extension manager #4876

Merged
merged 1 commit into from
Apr 16, 2019
Merged

deprecate extension manager #4876

merged 1 commit into from
Apr 16, 2019

Conversation

akosyakov
Copy link
Member

fix #4693

I've not found any references in docs and will remove it from theia-full image.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@kittaakos
Copy link
Contributor

Why do not we delete the extension?

@akosyakov
Copy link
Member Author

Why do not we delete the extension?

We want to reuse it: https://github.com/theia-ide/theia/pull/4876/files#diff-95c0da6ee742fdb8fe813a2b4c935919R3

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not want to remove the source and want to compile it although it is unused; it looks good to me.

Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Anton

@akosyakov akosyakov merged commit 2d0f27e into master Apr 16, 2019
@akosyakov akosyakov deleted the GH-4693 branch April 16, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get rid of references to extension-manager everywhere
3 participants