-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[keybindings] align keybindings-widget with vscode #5545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely. Like the jsdoc comments!
I don't understand,
They are still displayed. If a command does not have a
That's untrue. If you look closely, commands with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks Fine,
the commands without key bindings are there, I probably had a search criteria that was not clear while doing the testing
Thanks @vince-fugnitto
No problem! :) |
I'll hold the PR for after the release to see if anyone else has comments. |
Fixes #5544 The purpose of the PR is to align the behavior and look of the keybindings-widget more closely with that of vscode. Features present in the PR: 1. removed the `command id` column. 2. renamed the `scope` column to `source`. 3. display the command id for commands without a label. 4. re-order the columns to that of vscode (actions, command, keybinding, source). 5. prioritized the display of commands with keybindings before those without. 6. updated the documentation. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
7f24763
to
b69c463
Compare
Fixes #5544
The purpose of the PR is to align the behavior and look of the
keybindings-widget more closely with that of vscode.
Features present in the PR:
command id
column.scope
column tosource
.Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com