Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keybindings] align keybindings-widget with vscode #5545

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Conversation

vince-fugnitto
Copy link
Member

Fixes #5544

The purpose of the PR is to align the behavior and look of the
keybindings-widget more closely with that of vscode.

Features present in the PR:

  1. removed the command id column.
  2. renamed the scope column to source.
  3. display the command id for commands without a label.
  4. re-order the columns to that of vscode (actions, command, keybinding, source).
  5. prioritized the display of commands with keybindings before those without.
  6. updated the documentation.

image

Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added keybindings issues related to keybindings ui/ux issues related to user interface / user experience labels Jun 20, 2019
@vince-fugnitto vince-fugnitto self-assigned this Jun 20, 2019
Copy link

@fangnx fangnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely. Like the jsdoc comments!

@vince-fugnitto
Copy link
Member Author

vince-fugnitto commented Jun 20, 2019

@lmcbout

If I compare with old values, there are some some command missing: i.e. "Unstage all" + other commands.

I don't understand, unstage all is present.

Screen Shot 2019-06-20 at 5 25 24 PM

Second, what about the commands which don't have a name, they used to show.

They are still displayed. If a command does not have a label it displays its id instead.

It looks like we only see the command having a keybinding defined for them.

That's untrue. If you look closely, commands with keybindings are displayed first, then those without are displayed.

Copy link
Contributor

@lmcbout lmcbout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks Fine,
the commands without key bindings are there, I probably had a search criteria that was not clear while doing the testing
Thanks @vince-fugnitto

@vince-fugnitto
Copy link
Member Author

Thanks @vince-fugnitto

No problem! :)

@vince-fugnitto
Copy link
Member Author

I'll hold the PR for after the release to see if anyone else has comments.

Fixes #5544

The purpose of the PR is to align the behavior and look of the
keybindings-widget more closely with that of vscode.

Features present in the PR:
1. removed the `command id` column.
2. renamed the `scope` column to `source`.
3. display the command id for commands without a label.
4. re-order the columns to that of vscode (actions, command, keybinding, source).
5. prioritized the display of commands with keybindings before those without.
6. updated the documentation.

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings issues related to keybindings ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[keybindings] align keybindings-widget with vscode
3 participants