support workspaceContains activation events

[akosyakov]

What it does

• [vscode] support activation events #4199: support workspaceContains activation events
• https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20357 - a CQ for copied code

How to test

• install test plugins: https://github.com/akosyakov/workspace-containts-activation-event/blob/master/plugins.tar
• start Theia and open theia repo
• you should see 2 extensions activated:
  • one by a relative file path to packages/core/package.json
  • another via glob search **/core/package.json
• if you open another repo you should not see notifications

See how to install VS Code extensions: https://github.com/theia-ide/theia/wiki/Testing-VS-Code-Extensions

Review checklist

• as an author, I have thoroughly tested my changes and carefully reviewed in accordance with the review guideline

Reminder for reviewers

• each approve has supporting comments in accordance with the review guideline
• the approve without a comment should be dismissed

[akosyakov]

It is ready for the review. You can also try rust extension, all activation events for it should be supported now.

[akosyakov]

@BroKun if you want to get more involved feel free to review PRs as well. Community help is always welcomed in any form.

[kittaakos]

I am reviewing this...

[kittaakos]

It worked for me, I could see the expected two plug-in activations.
It did not happen when I tried with another repository than Theia.

[akosyakov]

@kittaakos I've addressed your comments, please have a look again.

[kittaakos]

please have a look again.

👍

I have tried it again from a fresh clone, copied the two plugins to the plugins folder:

• I could see the two notification after opening a workspace on theia.
• I did not experience any plugin activations when I opened a workspace on a different repository.

[akosyakov]

@marcdumais-work I need it to resolve #5661 properly. Can we proceed with merging? a CQ for 5 lines from VS Code repo with MIT license

[marcdumais-work]

@marcdumais-work I need it to resolve #5661 properly. Can we proceed with merging? a CQ for 5 lines from VS Code repo with MIT license

Let me have a look...

[marcdumais-work]

@akosyakov It seems to me that the CQ in this specific case is a formality:

• MIT license is "compatible"
• this area of the code looks to be 100% original Microsoft code
• you added the original Microsoft license header

So I am personally ok to merge without waiting, if we accept a small risk that we may have missed something and, in that case, we might need to go back and potentially roll-back this PR.

Also, we will need the CQ approved before the next release, so we are "license certified".

[akosyakov]

a CQ was approved, merging