Fixed #4897: supported tab details to disambiguate identical names

[fangnx]

What it does

Fixed #4897.

• Supported additional tab details for tabs with identical titles.
• If there existed multiple tabs with the same name, each tab would have its partial relative path displayed after the title.
  

How to test

• Open files with identical names in a tab bar (e.g., index.ts from different directories), and they should have a partial path displayed for the purpose of disambiguation.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to review in accordance with the review guidelines

[vince-fugnitto]

Is this the intended behavior?
I don't get any distinction between identical file names in different main-area groups.
I see that VSCode does something similar, but shouldn't we be better in this case? It'd be a lot easier to identify identical file names regardless of where they are situated in the main area.

Maybe a second opinion would be good.

[fangnx]

Is this the intended behavior?
I don't get any distinction between identical file names in different main-area groups.
I see that VSCode does something similar, but shouldn't we be better in this case? It'd be a lot easier to identify identical file names regardless of where they are situated in the main area.

Maybe a second opinion would be good.

Yes, this is the intended behaviour when I implemented it. The code is in TabBarRenderer and it is only possible to get editors present in one specific tab bar. I did not find a way (and the appropriate place) to merge editors from all tab bars and parse them, so I decided to do what VS Code has for now.

[vince-fugnitto]

Yes, this is the intended behaviour when I implemented it. The code is in TabBarRenderer and it is only possible to get editors present in one specific tab bar. I did not find a way (and the appropriate place) to merge editors from all tab bars and parse them, so I decided to do what VS Code has for now.

That sounds fine, I'm fine with having the same behavior as VSCode as well :)
I think it can be a future enhancement to also allow the functionality irregardless of the main panel groups.

[vince-fugnitto]

We can avoid the suppression of the tslint check by updating the code from:

expect(pathMap.get(tabPaths[6])).to.be.undefined;

To:

expect(pathMap.get(tabPaths[6])).to.be.equal(undefined);

[vince-fugnitto]

Can we follow the pattern present in other tests?
Namely,

it('should...')

Example:
https://github.com/theia-ide/theia/blob/17bfcb2eee69acccade5106de050576f6c46206a/packages/core/src/common/command.spec.ts#L30-L36

[fangnx]

Sure!

[lmcbout]

I open a multi-root workspace and I have the following file in each root folder:

• root1/.theia/tasks.json
• root2/.theia/tasks.json

Both are reported as : .theia/tasks.json
There is no distinction when I open the same file from two differents roots

[fangnx]

I open a multi-root workspace and I have the following file in each root folder:

• root1/.theia/tasks.json
• root2/.theia/tasks.json

Both are reported as : .theia/tasks.json
There is no distinction when I open the same file from two differents roots

Thanks for the feedback! I will test it and then address this issue

[fangnx]

I open a multi-root workspace and I have the following file in each root folder:

• root1/.theia/tasks.json
• root2/.theia/tasks.json

Both are reported as : .theia/tasks.json
There is no distinction when I open the same file from two differents roots

I just rebased the PR to the latest master. Please let me know if it still does not work (it works on my side) ;)

[lmcbout]

Few minor comments
The test does not execute
Otherwise, code + execution looks nice, works well

[vince-fugnitto]

@fangnx in order to fix the test:

import { enableJSDOM } from '../test/jsdom';
let disableJSDOM = enableJSDOM();

import { expect } from 'chai';
import { Title, Widget } from '@phosphor/widgets';
import { TabBarRenderer } from './tab-bars';

disableJSDOM();

describe('tab bar', () => {

    before(() => {
        disableJSDOM = enableJSDOM();
    });

    after(() => {
        disableJSDOM();
    });

    ...

---

We need to make sure to clean up after testing due to enableJSDOM.

[vince-fugnitto]

@lmcbout do you mind completing the review and merging if it's fine?

[lmcbout]

LGTM
Nice works @fangnx