Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #5927: plugin ext file path error #5929

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

502647092
Copy link
Contributor

@502647092 502647092 commented Aug 13, 2019

What it does

fix: #5927

image

How to test

  • Press F1
  • Deploy Plugin By Id
  • input ext install ms-kubernetes-tools.vscode-kubernetes-tools
  • until install finish
  • refresh theia
  • the ext logo show correct

Review checklist

Reminder for reviewers

Signed-off-by: MiaoWoo <admin@yumc.pw>
@akosyakov
Copy link
Member

akosyakov commented Aug 13, 2019

@azatsarynnyy Could you check please that icons for kubernetes VS Code extension work well as before? Also after reloading a page.

@azatsarynnyy
Copy link
Member

@akosyakov sure, I'll test it today

@akosyakov akosyakov added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Aug 13, 2019
@azatsarynnyy
Copy link
Member

I've tested the PR and can confirm that it fixes the issue with icons
image

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @502647092 for detecting and fixing the bug!

@akosyakov
Copy link
Member

Let me check that it works with relative paths as well.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually they can be only relative 😄 If they are not it is a bug in the client code.

@akosyakov akosyakov merged commit 3be6caf into eclipse-theia:master Aug 13, 2019
@502647092 502647092 deleted the patch-1 branch August 13, 2019 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] vscode ext can't get file
3 participants