[git diff] fix the git-diff widget header details alignment #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5996 - fixes the `git-diff` widget header details but updating the css specifically for the `git-diff` widget header. Originally the `path` and `revision` details were not aligned properly and it has been resolved so that they are displayed inline with their values. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
git
elaihau
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
While testing I found #5999 but I don't think it is related to this pull request.
This change works great in both single and multi root workspace.
Also, I tried different width and height and the appearance of the git-diff view was not broken.
Thank you for your work !
|
@elaihau thank you for the review! I'll wait a while to see if anyone else has any comments :) |
|
@elaihau thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #5996
git-diffwidget header details but updating the cssspecifically for the
git-diffwidget header. Originally thepathandrevisiondetails were not aligned properly and it has been resolvedso that they are displayed inline with their values.
How to test
theia)packages/folder in the explorer and selectCompare With...path,revisionand forfiles changedis correct in thegit-diffheaderReview checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com