Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeepL translations #94

Closed
Zethson opened this issue Sep 17, 2021 · 2 comments · Fixed by #108
Closed

DeepL translations #94

Zethson opened this issue Sep 17, 2021 · 2 comments · Fixed by #108
Assignees
@Zethson
Labels
enhancement New feature or request

Comments

@Zethson
Copy link
Member

Zethson commented Sep 17, 2021 •
edited
Loading

Add Deepl integration to translate columns from language A to language B. Usually X to English.
https://github.com/DeepLcom/deepl-python

It should

  1. Handle authentication
  2. Allow for the replacement of an obs column or whether it should just be added
  3. Maybe add a warning that the quota may be exceeded? Test for how many translations are left before translating?
@Zethson Zethson added the enhancement New feature or request label Sep 17, 2021
@Zethson Zethson self-assigned this Sep 17, 2021
This was referenced Sep 22, 2021
Closed
Merged
@Zethson
Copy link
Member Author

Zethson commented Sep 27, 2021

https://github.com/nidhaloff/deep-translator

exists. But does not support all features of e.g. DeepL (yet). I shall think how we should proceed.

@Zethson
Copy link
Member Author

Zethson commented Sep 27, 2021

Might be good if I simply rewrap deep-translator as stupid as it sounds because the API is also not consistent....

@Zethson Zethson linked a pull request Oct 6, 2021 that will close this issue
add DeepL translation #108
Merged
@Zethson Zethson changed the title Translations DeepL translations Oct 6, 2021
@Zethson Zethson closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zethson Zethson

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add DeepL translation theislab/ehrapy
1 participant
@Zethson