Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DeepL translation #108

Merged
merged 20 commits into from
Oct 7, 2021
Merged

add DeepL translation #108

merged 20 commits into from
Oct 7, 2021

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Sep 27, 2021

#94

This PR adds

  1. Integration with DeepL
  2. Tests for DeepL which can only be run with a token

We still need methods to easily update AnnData objects with these translations. Might be this PR, might also get a follow up PR.

Signed-off-by: zethson lukas.heumos@posteo.net

Signed-off-by: zethson <lukas.heumos@posteo.net>
@github-actions github-actions bot added the enhancement New feature or request label Sep 27, 2021
Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson Zethson marked this pull request as draft September 27, 2021 14:03
@Zethson Zethson marked this pull request as draft September 27, 2021 14:03
@Zethson Zethson marked this pull request as draft September 27, 2021 14:03
@Zethson Zethson marked this pull request as draft September 27, 2021 14:03
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson
Copy link
Member Author

Zethson commented Sep 28, 2021

I should ensure that we have 3 ways to translate

  1. translate obs (done)
  2. translate var (missing!)
  3. translate X (WIP)

Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson Zethson requested a review from Imipenem October 6, 2021 11:09
@Zethson Zethson marked this pull request as ready for review October 6, 2021 11:12
Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
@@ -11,3 +11,7 @@ td:nth-child(1) {
td:nth-child(2) {
width: 100%;
}

span.pre {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy with this, but required because the whole span is black elsewise and unreadable. Not sure whether this is an issue with our stuff or just the dark mode extension. Likely the extension...

@Imipenem ideas?

Signed-off-by: zethson <lukas.heumos@posteo.net>
Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson Zethson linked an issue Oct 6, 2021 that may be closed by this pull request
ehrapy/api/tools/nlp/_translators.py Show resolved Hide resolved
ehrapy/api/tools/nlp/_translators.py Show resolved Hide resolved
ehrapy/api/tools/nlp/_translators.py Show resolved Hide resolved
ehrapy/api/tools/nlp/_translators.py Show resolved Hide resolved
ehrapy/api/tools/nlp/_translators.py Outdated Show resolved Hide resolved
ehrapy/api/tools/nlp/_translators.py Show resolved Hide resolved
tests/_test_util.py Outdated Show resolved Hide resolved
tests/_test_util.py Show resolved Hide resolved
Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson Zethson merged commit 9822c24 into development Oct 7, 2021
@Zethson Zethson deleted the feature/translations branch October 7, 2021 15:55
@Zethson Zethson restored the feature/translations branch October 7, 2021 15:55
@Zethson Zethson deleted the feature/translations branch November 2, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepL translations
2 participants