Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix neighbors calculation #1233

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Fix neighbors calculation #1233

merged 6 commits into from
Apr 12, 2024

Conversation

WeilerP
Copy link
Member

@WeilerP WeilerP commented Apr 12, 2024

Changes

  • Add deprecation warnings.

Bug fixes

  • Remove write_knn_indices when computing neighbors with Scanpy.
  • Fix unit tests for neighbors

Related issues

Closes #1212.

Remove redundant argument.
Update according to latest API changes in scvelo and scanpy.
Add warning that neighbors and PCA will not be calculated automatically
in the future.
@WeilerP WeilerP force-pushed the fix/neighbors branch 7 times, most recently from 9ac6ad4 to 7dd3d9f Compare April 12, 2024 14:53
@WeilerP WeilerP added this pull request to the merge queue Apr 12, 2024
Merged via the queue into theislab:main with commit 6a0b63d Apr 12, 2024
6 checks passed
@WeilerP WeilerP deleted the fix/neighbors branch April 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neighbors.compute_neighbors() got an unexpected keyword argument 'write_knn_indices'
1 participant