Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing to relative path #50

Open
danielStrobl opened this issue Sep 29, 2022 · 1 comment
Open

Writing to relative path #50

danielStrobl opened this issue Sep 29, 2022 · 1 comment
Assignees
@xlancelottx @LouisK92

Comments

@danielStrobl
Copy link
Contributor

Hey! I've just noticed an issue with the generate_adata function. We're writing to a relative path that might not exist, is this intended? Do we even need to write an intermediate file here?

txsim/txsim/preprocessing/_countgeneration.py

Line 62 in ce33370

adata.write_h5ad('data/adata_st_temp.h5ad')

@LouisK92
Copy link
Contributor

Hm yea was added by @xlancelottx in PR #40 - was probably only for testing, right @xlancelottx?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xlancelottx xlancelottx

@LouisK92 LouisK92

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xlancelottx @LouisK92 @danielStrobl