Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sidebar in mobile when it open #807

Closed
2 of 11 tasks
sli1989 opened this issue Apr 4, 2019 · 4 comments · Fixed by #808
Closed
2 of 11 tasks

No sidebar in mobile when it open #807

sli1989 opened this issue Apr 4, 2019 · 4 comments · Fixed by #808

Comments

@sli1989
Copy link
Collaborator

sli1989 commented Apr 4, 2019

I agree and want to create new issue


Actual behavior

so in my site

sidebar:
  # Sidebar Position, available value: left | right (only for Pisces | Gemini).
  position: left
  # Sidebar Display, available value (only for Muse | Mist):
  #  - post    expand on posts automatically. Default.
  #  - always  expand for all pages automatically
  #  - hide    expand only when click on the sidebar toggle icon.
  #  - remove  Totally remove sidebar including sidebar toggle.
  display: post
  # Sidebar offset from top menubar in pixels (only for Pisces | Gemini).
  offset: 12
  # Enable sidebar on narrow view (only for Muse | Mist).
  onmobile: true
  # Click any blank part of the page to close sidebar (only for Muse | Mist).
  dimmer: false

back2top:
  enable: true
  # Back to top in sidebar.
  sidebar: false
  # Scroll percent label in b2t button.
  scrollpercent: true

sidebar disappear in mobile.

Steps to reproduce the behavior

  1. N/A
  2. N/A
  3. N/A
  • Link to demo site with this bug: N/A
  • Link(s) to source code or any usefull link(s): N/A

Node.js and NPM Information


Package dependencies Information


Hexo Information

Hexo version


Hexo Configuration

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

Other Information

@sli1989 sli1989 added the Bug label Apr 4, 2019
@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Apr 4, 2019

According to line 1790 of /css/main.css, I think some configurations are wrong. It happens only when sidebar.onmobile == false

屏幕快照 2019-04-04 上午9 39 27
屏幕快照 2019-04-04 上午9 39 42

@ivan-nginx ivan-nginx changed the title no sidebar in mobile when it open No sidebar in mobile when it open Apr 4, 2019
@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 4, 2019

@stevenjoezhang it seems you soon modified sidebar and after that onmobile now broken. So, fix it.

@ivan-nginx
Copy link
Member

ivan-nginx commented Apr 4, 2019

Bug detected in #728.

Also, back2top broken somewhere too. In Muse / Mist schemes. Was in sidebar.

stevenjoezhang added a commit that referenced this issue Apr 4, 2019
* Fix #807

* Add `$b2t-opacity-hover` & Remove hover highlight
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this issue Nov 19, 2019
* Fix theme-next#807

* Add `$b2t-opacity-hover` & Remove hover highlight
@lock
Copy link

lock bot commented Apr 4, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. It is possible issue was solved or at least outdated. Feel free to open new for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants