-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom sidebar width & content width for all schemes. #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added alias `alert` to `note` tag.
1. Added Codacy badge. 2. Added Feedback section. 3. Main status badges are centered from now.
1. [BR]: Removed `max_content_width` setting (which was only for Gemini scheme). 2. [BR]: renamed `sidebar_width` to `sidebar.width` option (moved from global to section to section under `sidebar`). 3. Added `desktop-largest()` condition and setted to >1600px. Old `desktop-large()` now redefined to >1200px. Added new `$content-desktop-largest` variable. 4. Replaced `$main-desktop` & `$main-desktop-large` variables with standard `$content-desktop` & `$content-desktop-large` for Pisces/Gemini schemes. 5. Moved `$sidebar-desktop` variable from global `base.styl` variables file to `Pisces.styl` (because it's only for Pisces/Gemini). 6. Moved layout global styles variables from `Gemini.styl` to `Pisces.styl`.
3 tasks
ivan-nginx
requested review from
Acris,
flashlab,
Raincal,
Blealtan,
geekrainy,
sli1989 and
maple3142
July 4, 2018 16:24
Old config
This is a little hard. |
Jona-lee
pushed a commit
to Jona-lee/hexo-theme-next
that referenced
this pull request
Oct 10, 2018
* Custom sidebar width & content width for all schemes. 1. [BR]: Removed `max_content_width` setting (which was only for Gemini scheme). 2. [BR]: renamed `sidebar_width` to `sidebar.width` option (moved from global to section to section under `sidebar`). 3. Added `desktop-largest()` condition and setted to >1600px. Old `desktop-large()` now redefined to >1200px. Added new `$content-desktop-largest` variable. 4. Replaced `$main-desktop` & `$main-desktop-large` variables with standard `$content-desktop` & `$content-desktop-large` for Pisces/Gemini schemes. 5. Moved `$sidebar-desktop` variable from global `base.styl` variables file to `Pisces.styl` (because it's only for Pisces/Gemini). 6. Moved layout global styles variables from `Gemini.styl` to `Pisces.styl`.
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
* Custom sidebar width & content width for all schemes. 1. [BR]: Removed `max_content_width` setting (which was only for Gemini scheme). 2. [BR]: renamed `sidebar_width` to `sidebar.width` option (moved from global to section to section under `sidebar`). 3. Added `desktop-largest()` condition and setted to >1600px. Old `desktop-large()` now redefined to >1200px. Added new `$content-desktop-largest` variable. 4. Replaced `$main-desktop` & `$main-desktop-large` variables with standard `$content-desktop` & `$content-desktop-large` for Pisces/Gemini schemes. 5. Moved `$sidebar-desktop` variable from global `base.styl` variables file to `Pisces.styl` (because it's only for Pisces/Gemini). 6. Moved layout global styles variables from `Gemini.styl` to `Pisces.styl`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): #150, #184
Pull Number(s): #111, #103
What is the new behavior?
max_content_width
setting (which was only for Gemini scheme).sidebar_width
tosidebar.width
option (moved from global to section to section undersidebar
).desktop-largest()
condition and setted to >1600px. Olddesktop-large()
now redefined to >1200px. Added new$content-desktop-largest
variable.$main-desktop
&$main-desktop-large
variables with standard$content-desktop
&$content-desktop-large
for Pisces/Gemini schemes.$sidebar-desktop
variable from globalbase.styl
variables file toPisces.styl
(because it's only for Pisces/Gemini).Gemini.styl
toPisces.styl
.How to use?
Change sidebar width
In NexT
_config.yml
:Change content width
By default, Pisces and Gemini schemes adapted under high-screen resolutions.
Muse and Mist have old 900px value with >=1600px desktop.
You can change variables in
source/css/_variables/custom.styl
:For example, for Muse / Mist under high-screen resolutions:
OR
P.S. Docs will be ASAP in site. Please, be patient and wait.
Does this PR introduce a breaking change?