-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force include source/lib/font-awesome/ #832
Conversation
Thanks so much for opening your first PR here! |
Seems it's okey, now please sign CLA and we will merge it. All checks must be passed. |
Seems this issue: #413 has been resolved? |
Yes, the issue described about what this PR solved. But there isn't I did't build this repo in local machine and almost know nothing about nodejs, so I don't now whether the directory will be generated by developing tools. Should add other exclude rule in it? |
@stevenjoezhang pull verified by you? |
@ivan-nginx Verified. |
Congrats on merging your first pull request here! 🎉 How awesome! |
PR Type
What kind of change does this PR introduce?
.gitignore
What is the current behavior?
The origin version was
!source/lib/font-awesome/*
, but it doesn't work. While I published my blog through Travis CI, It didn't include the font-awersome lib. And my Git GUI told that the dir was excluded by .gitignore.Issue resolved: #413
What is the new behavior?
Now it works.
Does this PR introduce a breaking change?