Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force include source/lib/font-awesome/ #832

Merged
merged 1 commit into from
Jun 9, 2019
Merged

Force include source/lib/font-awesome/ #832

merged 1 commit into from
Jun 9, 2019

Conversation

zombie110year
Copy link
Contributor

@zombie110year zombie110year commented Apr 13, 2019

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

I don't know which type should be chose to describe this change, and it didn't need test.

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe: Modified .gitignore

What is the current behavior?

The origin version was !source/lib/font-awesome/*, but it doesn't work. While I published my blog through Travis CI, It didn't include the font-awersome lib. And my Git GUI told that the dir was excluded by .gitignore.

Issue resolved: #413

What is the new behavior?

Now it works.

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Apr 13, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2019

CLA assistant check
All committers have signed the CLA.

@ivan-nginx
Copy link
Member

Seems it's okey, now please sign CLA and we will merge it. All checks must be passed.

@ivan-nginx ivan-nginx added this to the v7.2.0 milestone Apr 13, 2019
@stevenjoezhang
Copy link
Contributor

Seems this issue: #413 has been resolved?

@zombie110year
Copy link
Contributor Author

Seems this issue: #413 has been resolved?

Yes, the issue described about what this PR solved. But there isn't font-awesome/dirty directory in the remote repo.

I did't build this repo in local machine and almost know nothing about nodejs, so I don't now whether the directory will be generated by developing tools.

Should add other exclude rule in it?

@ivan-nginx
Copy link
Member

@stevenjoezhang pull verified by you?

@stevenjoezhang stevenjoezhang modified the milestones: v7.1.1, 7.2.0 May 18, 2019
@1v9 1v9 modified the milestones: 7.1.2, v7.2.0 Jun 1, 2019
@1v9 1v9 changed the title Exclude source/lib/font-awesome from .gitignore Force include source/lib/font-awesome Jun 8, 2019
@1v9 1v9 changed the title Force include source/lib/font-awesome Force include source/lib/font-awesome/ Jun 8, 2019
@stevenjoezhang
Copy link
Contributor

@ivan-nginx Verified.

@stevenjoezhang stevenjoezhang merged commit aa667cc into theme-next:master Jun 9, 2019
@welcome
Copy link

welcome bot commented Jun 9, 2019

Congrats on merging your first pull request here! 🎉 How awesome!

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

仓库根目录 .gitignore 文件中的嵌套 exclusion 规则无效
5 participants