Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue about the algolia search overlay. #89

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

tsanie
Copy link
Contributor

@tsanie tsanie commented Jan 26, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Since the Muse layout specify the .site-nav is an absolute position with a z-index: 1030 in the mobile layout, that will lead its child .algolia-popup would be covered by the .algolia-pop-overlay (which with a z-index: 2080)

Issue Number(s): iissnan/hexo-theme-next#1764

What is the new behavior?

Set the .algolia-pop-overlay to be hidden in the mobile layout, because the .algolia-popup will fill the entire screen.

  • Screens with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

N/A

Does this PR introduce a breaking change?

  • Yes.
  • No.

Copy link
Member

@ivan-nginx ivan-nginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

P.S. Check it in roadmap: #67.

@tsanie tsanie merged commit 987258b into theme-next:master Jan 26, 2018
@ivan-nginx ivan-nginx mentioned this pull request Jan 26, 2018
72 tasks
@tsanie tsanie deleted the algolia-search-overlay branch January 26, 2018 08:17
@tsanie tsanie added this to the v6.0.3 milestone Jan 26, 2018
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Fix an issue about the algolia search overlay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants