Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($layout/page.swig): cutstom new layout of page #904

Closed
wants to merge 1 commit into from
Closed

feat($layout/page.swig): cutstom new layout of page #904

wants to merge 1 commit into from

Conversation

jingxinxin
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Cutstom new layout of page

Issue resolved: N/A

What is the new behavior?

Cutstom new layout of page

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

custom_file_path:
    page:
      url: source/_data/study.swig
      type: study
      script: study.js
...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Jun 8, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@1v9
Copy link
Member

1v9 commented Jun 8, 2019

Implementing only one custom page type is not good.
Support more custom page types or create a new page type completely.
Also you need to sign upstairs CLA and prepare docs for this feature.

@1v9 1v9 added this to the v7.2.0 milestone Jun 8, 2019
@stevenjoezhang
Copy link
Contributor

This feature seems unnecessary...

@jingxinxin
Copy link
Author

Implementing only one custom page type is not good.
Support more custom page types or create a new page type completely.
Also you need to sign upstairs CLA and prepare docs for this feature.

@1v9 yep,It's just a sudden idea I had when I was expanding the page, and I immediately came up with it. Customizing multiple pages is definitely needed.
@stevenjoezhang Mainly I want to ensure the purity of the original library. I don't want to modify the files in theme path.
At the same time, I can also expand the pages.

@stevenjoezhang
Copy link
Contributor

@jingxinxin We can use a survey to determine how many users need this feature. People who aren't as good at programming as you are may be confused by this feature.

@stevenjoezhang
Copy link
Contributor

Thanks for your contributing. Custom new layout of page is a high-end feature that requires a lot of template changes to allow users to implement their ideas. There is no point in trying to use a generic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants