-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typography field doesn't list standard font-families (Arial, Verdana ...) #1189
Comments
Actually standard fonts are like this: Serif
Sans-Serif
Monospace
You can see the stack here: 'Monaco,"Lucida Sans Typewriter","Lucida Typewriter","Courier New",Courier,monospace' The reason they are displayed in the dropdown as simply serif/sans-serif/monospace is space-saving and nothing more. If you select Serif, then |
Hello aristath, Sorry for opening this up again. I'm only just now continuing the typography on my theme. I am very confused on why you would group the standard fonts together by "style". Grouping them all together doesn't really make sense to me, since they are all completely different looking fonts. Example: The way the typography field currently is in kirki, is that if I select I really think all the standard web fonts as listed here: http://www.w3schools.com/cssref/css_websafe_fonts.asp should have their own selection field in the drop down. This current way of grouping them together is not really the way the fonts should be used. |
The reason they are grouped is because not all operating systems have all fonts. Example: add_filter( 'kirki/fonts/standard_fonts', function( $fonts ) {
$fonts['sans-serif'] = array(
'label' => 'Sans Serif',
'stack' => 'Arial,Helvetica,sans-serif',
);
return $fonts;
} ); |
Yes that is true that they are not all supported, however that is why these fonts along with the fallback fonts are listed as web safe fonts, since they are the most cross-platform supported fonts, along with the closest fallback fonts. So whatever a user chooses, it will be the most cross-platform compatible solution out there. These combinations of web safe have been used since the late 90s, and is common practice for web developers. I would honestly recommend to include it the way it's listed at http://www.w3schools.com/cssref/css_websafe_fonts.asp In the selection field, only display the first Font, and in the actual css, include the suggested fallbacks. I am using this array.
|
Issue description:
I noticed this a few months ago, that the font-families in the typography field, don't display any of the standard font-families, such as Arial, Verdana, Helvetica etc. Those are without a doubt a must have.
Here is a list of all those fonts: http://www.w3schools.com/cssref/css_websafe_fonts.asp
Also, I noticed that in the drop down menu for the font-families, there is "serif", "sans serif" and "monospace" listed. I would suggest to remove them, since those are generic families used as fallbacks by browsers.
Version used:
Latest github
Using theme_mods or options?
theme_mods
Code to reproduce the issue (config + field(s))
The text was updated successfully, but these errors were encountered: