Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Fonts load twice #1923

Open
imthat opened this issue Jun 13, 2018 · 6 comments
Open

Google Fonts load twice #1923

imthat opened this issue Jun 13, 2018 · 6 comments

Comments

@imthat
Copy link

imthat commented Jun 13, 2018

Issue description:

Google fonts load twice in the front end, any one having the same issue?

WebFont.load({google:{families:['Muli:700,600:cyrillic,cyrillic-ext,devanagari,greek,greek-ext,khmer,latin,latin-ext,vietnamese,hebrew,arabic,bengali,gujarati,tamil,telugu,thai']}});
WebFont.load({google:{families:['Muli:700,600:cyrillic,cyrillic-ext,devanagari,greek,greek-ext,khmer,latin,latin-ext,vietnamese,hebrew,arabic,bengali,gujarati,tamil,telugu,thai']}});

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
3.033

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

Typography field

@aristath aristath added the bug label Jun 20, 2018
@aristath
Copy link
Contributor

@imthat do you by any chance have 2 different kirki configs defined on your theme?

@imthat
Copy link
Author

imthat commented Jun 20, 2018

Here's my config setting:

Kirki::add_config( 'theme_id', array(
	'capability'    => 'edit_theme_options',
	'option_type'   => 'theme_mod',
));

function theme_kirki_configuration( $config ) {
	return wp_parse_args(array(
		'logo_image'   => '',
		'description'  => 'theme',
		'color_accent' => '#006799',
		'color_back'   => '#FFFFFF',
		'disable_loader' => true,
		'disable_output' => false,
	));
}
add_filter( 'kirki_config', 'theme_kirki_configuration' );

If only use global config without theme config, everything's okay.
If only use theme config, or use them both, fonts will load twice.
Kirki is bundled in a theme not as plugin.

Should I only use global config?

@aristath
Copy link
Contributor

can you send me a copy of your theme so that I may debug this?

@imthat
Copy link
Author

imthat commented Jun 20, 2018 via email

@niklasp
Copy link

niklasp commented Nov 21, 2018

how is the status of this issue? #2026

@aristath
Copy link
Contributor

how is the status of this issue?

Issue still exists, it is confirmed but doesn't actually cause any issues or impede performance in any way so it's not on the top of the long list of things to fix.
It will get fixed, but only after a few other more serious bugs have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants