fixes #1892, fixes #1888 #1901
Merged
fixes #1892, fixes #1888 #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1901 +/- ##
=========================================
Coverage 3.14% 3.14%
Complexity 1798 1798
=========================================
Files 143 143
Lines 6303 6303
=========================================
Hits 198 198
Misses 6105 6105
Continue to review full report at Codecov.
|
aristath
approved these changes
May 17, 2018
|
Confirmed & merged, thank you! I'll be releasing an update in a few minutes with this + another bugfix for the google-fonts implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1888 happens, because the previous fix for multiple-select field (3526db7) caused the non-multiple-select fields not showing the registered value. Change in the controls/php/class-kirki-control-repeater.php should fix that.
#1892 has partly the same issue, however it reports an unrelated bug as well, which is non-multiple-select fields not initiating the default value (values not yet in the database) with selectWoo (thus "null" is printed as reported in the issue). Change in the controls/js/src/repeater.js should fix that. If no value is defined in the database, selectWoo will initiate with the default value of this select field.