From e46d9fa4d6bbc22bbdc2f0473cf337de96154e75 Mon Sep 17 00:00:00 2001 From: mlobstein Date: Sat, 6 Feb 2021 20:32:34 -0600 Subject: [PATCH] [epsonprojector] Always set ready=true on disconnect and improve documentation (#10079) * Always set ready on disconnect and improve documentation * improve documentation Signed-off-by: Michael Lobstein Signed-off-by: John Marshall --- bundles/org.openhab.binding.epsonprojector/README.md | 6 +++--- .../epsonprojector/internal/EpsonProjectorDevice.java | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bundles/org.openhab.binding.epsonprojector/README.md b/bundles/org.openhab.binding.epsonprojector/README.md index 500ba4477d847..4f80e33217317 100644 --- a/bundles/org.openhab.binding.epsonprojector/README.md +++ b/bundles/org.openhab.binding.epsonprojector/README.md @@ -1,7 +1,7 @@ # Epson Projector Binding -This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in ethernet port, serial port or USB to serial adapter. -If your projector does not have a built-in ethernet port, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`. +This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in network (ethernet or Wi-Fi) port, serial port or USB to serial adapter. +If your projector does not have built-in networking, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`. ## Supported Things @@ -27,7 +27,7 @@ The `projector-serial` thing has the following configuration parameters: The `projector-tcp` thing has the following configuration parameters: - _host_: IP address for the projector or serial over IP device -- _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector +- _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector or Wi-Fi - _pollingInterval_: Polling interval in seconds to update channel states | 5-60 seconds; default 10 seconds Some notes: diff --git a/bundles/org.openhab.binding.epsonprojector/src/main/java/org/openhab/binding/epsonprojector/internal/EpsonProjectorDevice.java b/bundles/org.openhab.binding.epsonprojector/src/main/java/org/openhab/binding/epsonprojector/internal/EpsonProjectorDevice.java index 8e8651280743b..f1679c5c8bc47 100644 --- a/bundles/org.openhab.binding.epsonprojector/src/main/java/org/openhab/binding/epsonprojector/internal/EpsonProjectorDevice.java +++ b/bundles/org.openhab.binding.epsonprojector/src/main/java/org/openhab/binding/epsonprojector/internal/EpsonProjectorDevice.java @@ -206,11 +206,11 @@ public void connect() throws EpsonProjectorException { public void disconnect() throws EpsonProjectorException { connection.disconnect(); connected = false; + ready = true; ScheduledFuture timeoutJob = this.timeoutJob; if (timeoutJob != null) { timeoutJob.cancel(true); this.timeoutJob = null; - ready = true; } }