Migrated Account Functions to use Js SDK #609
Conversation
|
Hey, @angle943 how do you want to review the code? |
|
@angle943 maybe you can assign one of the other contributors/team members to review for us, then you only need to check it when we are ready to merge to development |
|
@zinoadidi i gave you write permissions in this repo. After you've reviewed, feel free to merge it to the |
| const block = await createBlock(primaryValidatorConfig, senderSigningKey, senderAccountNumber, txs); | ||
| const sender = new Account(senderSigningKey); | ||
| const balanceLock = await fetchAccountBalanceLock(senderAccountNumber, primaryValidatorConfig); | ||
| const block = sender.createBlockMessage(balanceLock, txs); | ||
| await axios.post(`${address}/blocks`, block, { |
There was a problem hiding this comment.
@tomijaga The post requests here will be handled by sdk in later fix right ?
Or how is it suppose to work; I believe all interactions with chain will go through us eventually
There was a problem hiding this comment.
It would be handled when I implement the payment handler class
|
🥳 |
#585
thenewboston-blockchain/thenewboston-js#98
thenewboston-blockchain/thenewboston-js#99
thenewboston-blockchain/thenewboston-js#100
thenewboston-blockchain/thenewboston-js#101
thenewboston-blockchain/thenewboston-js#102