feat: support retrying requests when rate limited #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niallfitzy1
force-pushed
the
add-retry-logic-v4
branch
from
3c0acdd
to
59085df
Compare
theoephraim
reviewed
Oct 18, 2024
Added unit testing, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #418
Per the usage limits docs 429s should be handled by retrying, ideally by following an exponential back-off algorithm.
With this PR, you can provide the max retries & retry strategy you'd like to apply when rate limited.
When no configuration is provided, the library will default to the existing behaviour i.e. throw an error.
This is meant as a replacement for PR #525 that's ready to merge & has a more flexible interface for rate limiting.