Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate calculated Bitcoin deposit address with tBTC second track verification service #238

Closed
Tracked by #146
nkuba opened this issue Feb 12, 2024 · 0 comments · Fixed by #257
Closed
Tracked by #146
Assignees
Labels

Comments

@nkuba
Copy link
Member

nkuba commented Feb 12, 2024

No description provided.

@nkuba nkuba mentioned this issue Feb 12, 2024
@nkuba nkuba added the 🎨 dApp dApp label Feb 12, 2024
kkosiorowska added a commit that referenced this issue Feb 27, 2024
#257)

Closes #238

This PR validates the calculated Bitcoin deposit address and tracks this
action in Sentry. It is based on the solution implemented in this
[PR](threshold-network/token-dashboard#386).

The verification outcome is attached to the telemetry data as two
additional fields:
- `verificationStatus` which can have three different values
- `valid`: verification service responded with the same address as the
generated one
  - `invalid`: verification service responded with a different address
  - `error`: request or verification service error
- `verificationResponse` which holds the complete request outcome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants