Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the type logic for the amount #82

Closed
Tracked by #146
kkosiorowska opened this issue Dec 18, 2023 · 0 comments
Closed
Tracked by #146

Simplify the type logic for the amount #82

kkosiorowska opened this issue Dec 18, 2023 · 0 comments
Assignees
@kkosiorowska
Labels
🎨 dApp dApp
Milestone
MVP

Comments

@kkosiorowska
Copy link
Contributor

Originally posted by @r-czajkowski in #74 (comment)
@kkosiorowska kkosiorowska added this to the MVP milestone Dec 18, 2023
This was referenced Dec 18, 2023
Closed
Merged
@kkosiorowska kkosiorowska mentioned this issue Dec 27, 2023
Merged
r-czajkowski added a commit that referenced this issue Jan 2, 2024
@r-czajkowski
Simplify the formatting logic for CurrencyBalance (#94)
40883c6 
Closes #82 

The amount for `CurrencyBalance` can be of string or number type. We use
numbers in bigint format, which should be converted to the correct human
format. However, we should allow the use of the `CurrencyBalance`
component in case we don't need the formatting (simple value in USD).
For this, let's use the variable `shouldBeFormatted` and display it as a
local string.
@kkosiorowska kkosiorowska self-assigned this Jan 2, 2024
@nkuba nkuba mentioned this issue Jan 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkosiorowska kkosiorowska

Labels
🎨 dApp dApp
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@kkosiorowska