Basic configuration for chakra UI #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kkosiorowska
force-pushed
the
init-components
branch
from
bb6124d to
14ce39b
Compare
kkosiorowska
force-pushed
the
ledger-live-app
branch
from
4b74fc0 to
273d64f
Compare
There was a problem with the `import/no-extraneous-dependencies` rule for the new Chakra UI packages. Let's disable it at this step.
r-czajkowski
requested changes
Nov 16, 2023
We would like to be able to change the theme mode for the dApp. The mode should be detected for ledger live apps. Let's use an external chakra UI lib to create custom styles for components.
kkosiorowska
force-pushed
the
init-components
branch
from
f5dccfe to
0c3155e
Compare
Currently, the designs for the dark mode are not yet fully ready. Let's hide it under the feature flag to make sure that the page is displayed correctly.
kkosiorowska
force-pushed
the
init-components
branch
from
0c3155e to
14a1bb0
Compare
kkosiorowska
force-pushed
the
init-components
branch
from
42fd0c0 to
2275d38
Compare
r-czajkowski
approved these changes
Nov 20, 2023
nkuba
reviewed
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to be able to change the theme mode for the dApp. The mode should be detected for ledger live apps. Let's use an external chakra UI lib to create custom styles for components. This should make it easier to switch the theme for the components. Ten PR adds a basic configuration for chakra UI lib.
Chakra UI library has already been used in previous projects. It has prepared components and you can easily manage theme changes in the application by this lib. This should make development faster and easier.
What has been done
ChakraProviderUI
This PR only sets up the configuration for the chakra Ui library. Please ignore the differences between the button designs. The styles of the components will be fixed in the next PRs.
Dark mode
Light mode
Screen.Recording.2023-11-14.at.14.55.35.mov