Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dapp tests to the root test folder #906

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

nkuba
Copy link
Member

@nkuba nkuba commented Nov 28, 2024

Depends on: #904

For consistency with other packages and projects we are moving the dapp tests to the root test folder.

There are many possible approaches to organize the tests, but here we are following the same structure as the other packages. If we need to change this in the future, we can discuss and find the best approach.

For consistency with other packages and projects we are moving the dapp
tests to the root test folder.

There are many possible approaches to organize the tests, but here we
are following the same structure as the other packages.
If we need to change this in the future, we can discuss and find the best
approach.
@nkuba nkuba self-assigned this Nov 28, 2024
Base automatically changed from sentry-user-id to main November 28, 2024 12:01
@nkuba nkuba marked this pull request as ready for review November 28, 2024 14:18
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for acre-dapp ready!

Name Link
🔨 Latest commit 6c78ef0
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp/deploys/67487bd344c306000832fe4e
😎 Deploy Preview https://deploy-preview-906--acre-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for acre-dapp-testnet ready!

Name Link
🔨 Latest commit 6c78ef0
🔍 Latest deploy log https://app.netlify.com/sites/acre-dapp-testnet/deploys/67487bd3265e2500085bf992
😎 Deploy Preview https://deploy-preview-906--acre-dapp-testnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant