From 374ad8c6d0810b9aadfc00117fa1cbaa40c8be7d Mon Sep 17 00:00:00 2001 From: Adrian Bonislawski Date: Mon, 18 Mar 2024 10:50:59 +0100 Subject: [PATCH] ipc4: helper: fix checks in comp dir update - list_is_empty is required to properly check source list - at this stage empty list is allowed since source bind might not happen yet Signed-off-by: Adrian Bonislawski --- src/ipc/ipc4/helper.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ipc/ipc4/helper.c b/src/ipc/ipc4/helper.c index ad14bac53685..666df9bdea8f 100644 --- a/src/ipc/ipc4/helper.c +++ b/src/ipc/ipc4/helper.c @@ -803,8 +803,11 @@ static int ipc4_update_comps_direction(struct ipc *ipc, uint32_t ppl_id) if (icd->cd->direction_set) continue; + if (list_is_empty(&icd->cd->bsource_list)) + continue; + src_buf = list_first_item(&icd->cd->bsource_list, struct comp_buffer, sink_list); - if (src_buf && src_buf->source->direction_set) { + if (src_buf->source->direction_set) { icd->cd->direction = src_buf->source->direction; icd->cd->direction_set = true; continue;