From 236e357de37ae4032495807c1473292f7210ff9c Mon Sep 17 00:00:00 2001 From: Thomas Heller Date: Wed, 24 Apr 2024 09:55:06 +0200 Subject: [PATCH] fix comment --- src/main/shadow/build/npm.clj | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/shadow/build/npm.clj b/src/main/shadow/build/npm.clj index f625de7d..bf62de9d 100644 --- a/src/main/shadow/build/npm.clj +++ b/src/main/shadow/build/npm.clj @@ -91,7 +91,11 @@ {:prefix path :match match}) - ;; FIXME: are wildcards only allowed at end? + ;; wildcards are allowed to appear at the end and with additional suffix + ;; https://nodejs.org/api/packages.html#subpath-patterns + ;; although webpack makes it appear its only allowed at the end + ;; https://webpack.js.org/guides/package-exports/ + ;; leave :suffix nil if at the end, so later we know if that needs to be checked (if-some [star-idx (str/index-of path "*")] (update package :exports-wildcard util/vec-conj ;; strip * here, so we don't have to do it again later