Implement 2 buffers for receiving and sending #10
Conversation
Merge pull request knolleary#9 from MathewHDYT/master
…iting of received data when sending
|
@imbeacon Would be nice if this could be merged as well, and released as |
|
@MathewHDYT |
| if(pass != NULL) { | ||
| CHECK_STRING_LENGTH(length,pass) | ||
| length = writeString(pass,this->buffer,length); | ||
| length = writeString(pass,this->send_buffer,length); |
There was a problem hiding this comment.
unfortunately this breaks the password: If a password is available, it is appended to incorrect buffer and therefore not sent to server.
This makes the client never connect to password protected brokers.
Please release a new version. I will provide a PR tomorrow to fix this and some issues with keepalive handling.
There was a problem hiding this comment.
The password must be appended to the receive_buffer which is also used for sending username.
There was a problem hiding this comment.
@uschindler Already fixed in #12 Pull Request.
There was a problem hiding this comment.
Thanks very much! This issue is serious, so this PR should be merged soon. It makes it impossible to use a password for the broker.
When sending data in the user subscribed callbacks, of the
thingsboard-client-sdkit overwrites the received payload and therefore garbles up the response for all future callbacks that also wanted to handle that data.To fix that issue I've seperated the buffer into a receive and send buffer, so that even if you send data while handling received data the response will not be overwritten. This also fixes the previous need to copy the payload temporarily in the callback of the
thingsboard-client-sdk. Closes #8.Would be nice if this could be merged @imbeacon. So it can be released as
v2.10.0.