fix: connect() method - use correct buffer to write password into #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MQTT connect packet
|
@imbeacon Would be nice if this could be merged, and released as |
|
This is a serious issue, I have seen it while updating BSB-LAN project. It makes it impossible to connect when user/password combination is given on connection. |
This was referenced Dec 7, 2024
|
Hi @hb9xar, @MathewHDYT, @uschindler, Thank you for your participating in the project life, PR is merge and release is created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect(): when using username & password, the password string was written to the wrong buffer, resulting in a corrupt MQTT connect packet and connection failure.