From 97e1e157ff1fa53f748bb27382a8883418ecec46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= Date: Sun, 3 Jan 2021 10:26:09 +0100 Subject: [PATCH] [linuxinput] improve thread names (#9582) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See #9581 Signed-off-by: Thomas Weißschuh --- .../linuxinput/internal/DeviceReadingHandler.java | 2 +- .../linuxinput/internal/LinuxInputDiscoveryService.java | 2 +- .../org/openhab/binding/linuxinput/internal/Utils.java | 9 +++++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/DeviceReadingHandler.java b/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/DeviceReadingHandler.java index 5f98f3f09952f..82bbf82e4a6d5 100644 --- a/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/DeviceReadingHandler.java +++ b/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/DeviceReadingHandler.java @@ -63,7 +63,7 @@ public final void initialize() { logger.warn("Could not read event", e); updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, e.getMessage()); } - }, getClass(), getInstanceName()); + }, "events", thing); thread.start(); worker = thread; } diff --git a/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/LinuxInputDiscoveryService.java b/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/LinuxInputDiscoveryService.java index 0ef6f92d9516e..b92f56129ca0b 100644 --- a/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/LinuxInputDiscoveryService.java +++ b/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/LinuxInputDiscoveryService.java @@ -152,7 +152,7 @@ protected void startBackgroundDiscovery() { waitForNewDevices(watcher); return null; }); - Thread t = Utils.backgroundThread(job, getClass(), null); + Thread t = Utils.backgroundThread(job, "discovery", null); t.start(); discoveryJob = job; } else { diff --git a/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/Utils.java b/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/Utils.java index 26c71d012aaf9..2d9706ce43461 100644 --- a/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/Utils.java +++ b/bundles/org.openhab.binding.linuxinput/src/main/java/org/openhab/binding/linuxinput/internal/Utils.java @@ -14,6 +14,7 @@ import org.eclipse.jdt.annotation.NonNullByDefault; import org.eclipse.jdt.annotation.Nullable; +import org.openhab.core.thing.Thing; /** * Utilities @@ -25,10 +26,10 @@ class Utils { private Utils() { } - static Thread backgroundThread(Runnable r, Class clazz, @Nullable String instance) { - String name = LinuxInputBindingConstants.BINDING_ID + " :: " + clazz.getSimpleName(); - if (instance != null) { - name += " :: " + instance; + static Thread backgroundThread(Runnable r, String type, @Nullable Thing thing) { + String name = "OH-binding-" + LinuxInputBindingConstants.BINDING_ID + "-" + type; + if (thing != null) { + name += "-" + thing.getUID(); } Thread t = new Thread(r, name); t.setDaemon(true);