-
Notifications
You must be signed in to change notification settings - Fork 9
pin to trixie #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin to trixie #63
Conversation
WalkthroughUpdated Docker base images in server/Dockerfile: cargo-chef helper image from latest-rust-1 to latest-rust-1-trixie, and runtime image from debian:bookworm-slim to debian:trixie-slim. No build steps or commands changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
server/Dockerfile(2 hunks)
| @@ -1,5 +1,5 @@ | |||
| # Use cargo chef for dependency caching | |||
| FROM lukemathwalker/cargo-chef:latest-rust-1 AS chef | |||
| FROM lukemathwalker/cargo-chef:latest-rust-1-trixie AS chef | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Confirm cargo-chef trixie tag exists.
I’m not seeing documentation for lukemathwalker/cargo-chef:latest-rust-1-trixie; please verify the tag actually exists, otherwise the build will fail when the base image can’t be pulled.
Run this to confirm the tag is published:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
image="lukemathwalker/cargo-chef"
tag="latest-rust-1-trixie"
curl -s "https://hub.docker.com/v2/repositories/${image}/tags/?page_size=100" |
jq -e --arg tag "$tag" '.results[] | select(.name == $tag)' >/dev/null ||
{ echo "Tag $tag not found for $image"; exit 1; }
echo "Tag $tag is available for $image"Length of output: 64
Use a valid cargo-chef base image tag
The tag latest-rust-1-trixie does not exist on Docker Hub. Update line 2 in server/Dockerfile to reference a published tag for lukemathwalker/cargo-chef.
🤖 Prompt for AI Agents
server/Dockerfile lines 2-2: the FROM line uses a non-existent tag
`latest-rust-1-trixie`; update that line to reference a published
lukemathwalker/cargo-chef tag available on Docker Hub (e.g., pick the current
stable release tag or `latest` if present), then verify the chosen tag exists on
Docker Hub and rebuild to confirm the base image resolves.
Summary by CodeRabbit