-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deps] switch through
to @ljharb/through
#250
base: master
Are you sure you want to change the base?
Conversation
ping @bendrucker :-) |
I tried to make that happen in #251. The test suite is badly broken. Having second thoughts on whether this is in a positioned to be maintained versus just frozen/archived. |
I'm happy to take a crack at that - I can post a branch link in that PR for you to pull in. |
Sure, thank you! The difficulty is that this previously ran on iojs via Travis and wasn't kept up to date. So there's a mountain of dependency upgrades with cascading relationships to handle to get the tests running on the current LTS. I started going back to try to reproduce the existing test environment including installing iojs. The embedded CA certificates being outdated is understandable but even after disabling TLS verification there are still failing tests. I just pushed a change fixing the use of Turns out all that output was causing me to miss this, after the switch to iojs:
So in the short term I'm going to mark the peer dep as |
No luck, I've exhausted the time I can spend on this in the short term. A fix for browserify@16+ would be ideal. Otherwise disabling those tests is potentially the next best option. |
Note that changing peer deps is a breaking change. I'll be happy to post a branch link on your PR in the next few days; hopefully that will get everything up to speed. |
For these very old versions it's an error if the range doesn't match and so more clearly breaking. I thought that changed to a warning in years since. Part of the module has been broken with browserify@16/17 the whole time so to the extent the peer change is advisory and not mandatory I'd say it's not strictly breaking, at least if engines had required a sufficiently modern Node version where that peer dep handling was the case. Regardless, it's still easier to avoid those semver nuances. |
Because it affects |
Closes #249
npm test
fails locally because a transitive dev dep,osenv
, callsos.tmpDir
when the function is now namedos.tmpdir
, but I'm hoping CI accounts for that.