Skip to content

ci: use env.VERSION #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2025
Merged

ci: use env.VERSION #4146

merged 1 commit into from
Oct 26, 2025

Conversation

@thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Oct 26, 2025

No description provided.

@thomaspoignant
ci: use env.VERSION
4bdbbe7 
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@netlify
Copy link

netlify bot commented Oct 26, 2025 •
edited
Loading

✅ Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 4bdbbe7
🔍 Latest deploy log https://app.netlify.com/projects/go-feature-flag-doc-preview/deploys/68fe6c8ad43f0e0008822507

@thomaspoignant thomaspoignant merged commit b0fe88e into main Oct 26, 2025
18 of 20 checks passed
@thomaspoignant thomaspoignant deleted the env-version branch October 26, 2025 18:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@gofeatureflag-bot gofeatureflag-bot mentioned this pull request Oct 26, 2025
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 26, 2025
View reviewed changes
.github/workflows/release.yml
steps:
- name: Echo Release wasm version
run: |
echo "Release wasm version: ${{ env.VERSION }}"

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
.github/workflows/release.yml
with:
tinygo-version: "0.37.0"
- run: ./.github/ci-scripts/release_wasm.sh ${VERSION}
- run: ./.github/ci-scripts/release_wasm.sh ${{ env.VERSION }}

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
.github/workflows/release.yml
mkdir -p wasm-releases/evaluation
cp ./out/release-wasm/gofeatureflag-evaluation_${VERSION}.wasi wasm-releases/evaluation/
cp ./out/release-wasm/gofeatureflag-evaluation_${VERSION}.wasm wasm-releases/evaluation/
cp ./out/release-wasm/gofeatureflag-evaluation_${{ env.VERSION }}.wasi wasm-releases/evaluation/

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
.github/workflows/release.yml
cp ./out/release-wasm/gofeatureflag-evaluation_${VERSION}.wasi wasm-releases/evaluation/
cp ./out/release-wasm/gofeatureflag-evaluation_${VERSION}.wasm wasm-releases/evaluation/
cp ./out/release-wasm/gofeatureflag-evaluation_${{ env.VERSION }}.wasi wasm-releases/evaluation/
cp ./out/release-wasm/gofeatureflag-evaluation_${{ env.VERSION }}.wasm wasm-releases/evaluation/

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.93%. Comparing base (d923b26) to head (4bdbbe7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4146   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files         138      138           
  Lines        5643     5643           
=======================================
  Hits         4793     4793           
  Misses        644      644           
  Partials      206      206

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced Oct 26, 2025
Merged
Merged
@BrewTestBot BrewTestBot mentioned this pull request Oct 27, 2025
Merged
This was referenced Oct 27, 2025
Merged
Merged
@BrewTestBot BrewTestBot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thomaspoignant thomaspoignant

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomaspoignant