fix: prevent nil map assignment panic in /v1/allflags endpoint #4134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initialize custom map if nil in userRequestToUser function - Add comprehensive test cases for user and evaluation contexts without custom fields - Fixes issue #4133 where 500 error occurred due to nil map assignment The panic was occurring when processing requests where the user or evaluation context didn't include a 'custom' field, causing assignment to a nil map. This fix ensures the custom map is properly initialized before use.
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
=======================================
Coverage 83.76% 83.77%
=======================================
Files 139 139
Lines 6831 6835 +4
=======================================
+ Hits 5722 5726 +4
Misses 898 898
Partials 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a critical bug in the
/v1/allflagsendpoint that was causing a 500 Internal Server Error due to a nil map assignment panic.What was the problem?
The
/v1/allflagsendpoint was panicking with "assignment to entry in nil map" error when processing user requests that didn't include acustomfield in the user or evaluation context. This occurred in theuserRequestToUser()function at line 63 ofcmd/relayproxy/controller/utils.go.How it is resolved?
custommap in theuserRequestToUser()functioncustomfield is nil, it's now properly initialized as an empty map before assignmentHow can we test the change?
Closes issue(s)
Resolve #4133
Checklist