Skip to content

chore(cli): Add a test to validate the kebab case error #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Nov 12, 2025
Merged

chore(cli): Add a test to validate the kebab case error #4298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79746e3
chore(cli): Add a test to validate the kebab case error
thomaspoignant Nov 12, 2025
4514fb0
Merge branch 'main' into add-tests-for-kebab-case
thomaspoignant Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions cmd/cli/evaluate/evaluate_cmd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,51 @@ func TestCmdEvaluate(t *testing.T) {
wantErr: assert.Error,
expectedErr: "impossible to init flagset retriever: cannot parse `inv4lid`: failed to parse as keyword/value (invalid keyword/value)",
},
{
name: "should return RetrieverConfError with CLI-friendly message when required property is missing",
args: []string{
"--kind",
"github",
"--path",
"testdata/flag-config.yaml",
"--branch",
"master",
"--ctx",
`{"targetingKey": "user-123"}`,
"--format",
"yaml",
},
wantErr: assert.Error,
expectedErr: "invalid retriever: no \"repository-slug\" property found for kind \"github\"",
},
{
name: "should return RetrieverConfError with CLI-friendly message when path is missing for file kind",
args: []string{
"--kind",
"file",
"--ctx",
`{"targetingKey": "user-123"}`,
"--format",
"yaml",
},
wantErr: assert.Error,
expectedErr: "invalid retriever: no \"path\" property found for kind \"file\"",
},
{
name: "should return RetrieverConfError with CLI-friendly message when bucket is missing for s3 kind",
args: []string{
"--kind",
"s3",
"--item",
"config.yaml",
"--ctx",
`{"targetingKey": "user-123"}`,
"--format",
"yaml",
},
wantErr: assert.Error,
expectedErr: "invalid retriever: no \"bucket\" property found for kind \"s3\"",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
Expand Down
Loading