Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background #120

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Background #120

merged 11 commits into from
Dec 13, 2023

Conversation

thombruce
Copy link
Owner

@thombruce thombruce commented Nov 24, 2023

closes #118

By submitting this pull request, you agree to follow our Code of Conduct: https://github.com/thombruce/.github/blob/main/CODE_OF_CONDUCT.md


Internal use. Do not delete.

  • Tests passing
  • Coverage sufficient
  • Manual review
  • No A11y regression
  • Translations provided or not needed

@thombruce
Copy link
Owner Author

thombruce commented Nov 24, 2023

  • Consider adding Kataster and its author to Verse credits (it continues to be an incredibly valuable resource for me)
  • Consider adding Pablo Roman Andrioli to the credits too, whose shader the Kataster shader is based on

How we give these particular attributions I'm unsure... Special Thanks?

@thombruce
Copy link
Owner Author

Do play with the variables in Pablo's shader here: https://www.shadertoy.com/view/XlfGRj

Tweaking the values gives a real sense for what they actually do... Maybe leave formuparam alone though; effects of changing this are highly unpredictable, and whatever it is doing is wild alien magic.

@thombruce thombruce marked this pull request as ready for review November 24, 2023 14:05
@thombruce
Copy link
Owner Author

thombruce commented Nov 24, 2023

  • What do we want to do with the old background?

Deleted it; kept the assets. If we need it again we can reimplement from the Git history.

@thombruce thombruce closed this Nov 24, 2023
@thombruce thombruce reopened this Nov 24, 2023
@thombruce
Copy link
Owner Author

Problem:

Because the background now moves with the camera, and the camera moves with the player...

When we restart the game, the camera may be offset such that the respawned background is either only partially on screen or not on screen at all. We can see its edges, or the black ClearColor of the game window.

Ways to address this:

  1. Follow camera on every Update (not just active gamestate); this would ensure that it is appropriately positioned on reload
  2. Reset the camera position on game reset; this would ensure that the camera is positioned with the background in view

Either of those works, so pick a favourite. Probably option 2 since it doesn't require a system to run on update...

@thombruce thombruce merged commit b4d7f8c into main Dec 13, 2023
3 checks passed
@thombruce thombruce deleted the feat/background branch December 13, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better (Parallax) Backgrounds
1 participant