Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Rails 7.1 to the CI matrix to ensure the gem works with Rails 7.1.
This PR includes two commits to pass the test.
Ignore the directory that keeps factory files under the lib
Some tests put factory files under the
lib
. But since Rails 7.1, Rails loadslib
directory by default in a new application.https://guides.rubyonrails.org/7_1_release_notes.html#introducing-config-autoload-lib-and-config-autoload-lib-once-for-enhanced-autoloading
But factory files don't follow the naming rule of Zeitwerk. So Zeitwerk raises
Zeitwerk::NameError
. To avoid the error, thischanged to ignore the directory that puts factory files.
Remove the route that is defined by default
Some test code loads the route file twice. This wasn't a problem before Rails 7.0 because we didn't have a route.
But, Rails 7.1 has one route by default. So the test application raises the following error during the load.
The routing isn't a matter of this gem, so just ignore that for running the test.