Fix error messages for string responses #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- include test for failed string response - also fix `match_json_schema` typo in README (assuming this should be `match_response_schema`).
houndci-bot
reviewed
Nov 7, 2016
| end | ||
|
|
||
| it "fails with message when negated" do | ||
| expect { |
There was a problem hiding this comment.
Avoid using {...} for multi-line blocks.
houndci-bot
reviewed
Nov 7, 2016
| "id" => { "type" => "number" }, | ||
| }, | ||
| "additionalProperties" => false, | ||
| }) |
There was a problem hiding this comment.
Indent the right brace the same as the first position after the preceding left parenthesis.
houndci-bot
reviewed
Nov 7, 2016
| context "when JSON is a string" do | ||
| before(:each) do | ||
| create_schema("foo_schema", { | ||
| "type" => "object", |
There was a problem hiding this comment.
Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
houndci-bot
reviewed
Nov 7, 2016
| }) | ||
| context "when JSON is a string" do | ||
| before(:each) do | ||
| create_schema("foo_schema", { |
There was a problem hiding this comment.
Redundant curly braces around a hash parameter.
|
Released in https://github.com/thoughtbot/json_matchers/releases/tag/v0.6.3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
match_response_schemacan now accept a string (thanks to #43), I noticed it will cause aNoMethodErrorin error messages:This fix checks if response
respond_to?(:body)before attempting to call it from the error message. Included a test for failed string responses to ensure desired behavior.Also fixed what I think is a related typo in README:
match_json_schemashould bematch_response_schema, correct?