Validation error when listing deployments in the dashboard from other clients

[A-Harby]

Description

A clear description of the bug is:

Validation error from deployments made outside of the TS client, either go or terraform (name validation is different from go compared with the TS).

Must include any relevant identifiers like:

• Network: Devnet

• Version: ea66380

Steps to reproduce

• Deploy a VM or K8s from a Go client, CLI, TFRobot, or even Terraform.
• Navigate to the dashboard.
• Connect your wallet with the same account.
• Navigate to the deployment page and check the logs.

[ramezsaeed]

@A-Harby
this is only for logs, or the deployment is not shown if the validation is different ?

[A-Harby]

No, The deployments were listed, but I was only testing listing from other clients so maybe it could cause a problem with adding a domain in vms or works in the kubernetes from ts client

[Mahmoud-Emad]

What is the status here?

[amiraabouhadid]

Sorry for the delay took some time to investigate, was able to duplicate the error. Identifying the source of error in client.

[amiraabouhadid]

Might be caused by inconsistent type casting in client.

[amiraabouhadid]

error is due to missing validations for number of characters in name in go client which is inconsistent with the validation implemented in the ts client. @A-Harby please list any other missing validations in go client. Please also let us know if validations are missing in terraform

[A-Harby]

The naming validation is different for every client (TS, GO, and Terraform). Only the TS client has an alphanumeric validation naming for any deployment name, disk name, and network name with a minimum and maximum length.

while the terraform doesn't have any length validation and can accept underscores only beside alphanumeric, and the same goes for the Go client so far(there could be a difference in some cases).

[amiraabouhadid]

opened an issue for it in the go sdk here

[AhmedHanafy725]

check threefoldtech/tfgrid-sdk-go#1055 (comment)

[0oM4R]

should set the name length to 35 characters

tfgrid-sdk-ts/packages/grid_client/src/modules/models.ts

Line 28 in 95f7469

const NameLength = 50;

and check for dashboard name length validation as well

[A-Harby]

Verified, Devnet a004c81.

The Go client now has a length validation.

And the VM is showing successfully without any error.

But the VM isn't listed on the deployment page anymore, and I have reported it in a new issue.

[A-Harby]

Add a new test case on Dashboard Suite: TC2927 - List deployment from different clients

Update validation in CLI: TC1492 - Deploy VM