🐞 [Bug]: Normalize the virtual machine subdomain

[Mahmoud-Emad]

Is there an existing issue for this?

• I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

The subdomain is too long

Steps To Reproduce

1. Go to the Dashboard
2. Deploy a virtual machine
3. Try to attach a subdomain to it

which network/s did you face the problem on?

Dev

version

2.3.4

Twin ID/s

143

Node ID/s

NA

Farm ID/s

NA

Contract ID/s

NA

Relevant screenshots/screen records

Relevant log output

NA

[sameh-farouk]

Can users choose a subdomain without a prefix, if the name is not reserved? If not feasible, we can start with the user's chosen name and add a suffix afterward.

[ramezsaeed]

@sameh-farouk
I think the prefix is important even for the user himself; so he can relate this domain to his solution.
in case the user has multiples VMs with multiple domains; it will be easier to know which domain related to which VM with the prefix.

[zaelgohary]

Work completed:

Removed twinId & solution name and edited subdomain char limit to 5 + prefix (VM name).

[zaelgohary]

WIP:

Reverted previous changes and currently working on combining both the prefix and the subdomain as a name and allow the user to edit both. However, a validation would be triggered to check if a name contract exists with the same name or not to avoid post-deployment errors.

[zaelgohary]

Work completed:

Created a validation rule to check if a name contract with the same name exists on the chain or not. Edited the subdomain to include the prefix by default and changed the max limit to 15 instead of 35. Also, edited the subdomain tooltip and the name in the table accordingly.

[A-Harby]

After creating a domain, the same name validation isn't working.

Maybe you should randomize naming every time dialogue is reopened.
screen-capture (3).webm

[zaelgohary]

Work Completed:

Validate subdomain if tab is changed, change tab condition to v-if instead of v-show so the validation condition to work.

[A-Harby]

Verified, Devnet 17d861b.
The domain name is now validated with a minimum of 4 characters and a maximum of 30 characters, as well as validation for the same domain.
And the name given to the domain is a combination of solution type, twin ID, solution name, and a random character.
For the domain input size, I reported it separately here: #2842.

TC2124 - Add gateway to a vm