Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Maximum call stack size exceeded at SSHKeysManagement.migrate #2666

Closed
1 task done
Mahmoud-Emad opened this issue May 8, 2024 · 4 comments
Closed
1 task done
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@Mahmoud-Emad
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

There was a Maximum call stack size exceeded error in the SSH management service

Steps To Reproduce

  1. Import an old pattern of the SSH key
  2. go to the deployed version of the dashboard
  3. connect your wallet and open the console

which network/s did you face the problem on?

Dev

version

2.0.4

Twin ID/s

34

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

image

Relevant log output

[Uncaught Error]
- Message: Maximum call stack size exceeded
- Stack: RangeError: Maximum call stack size exceeded
   at SSHKeysManagement.migrate (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:41:22)
   at SSHKeysManagement.list (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:141:19)
   at SSHKeysManagement.generateName (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:89:31)
   at SSHKeysManagement.migrate (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:45:22)
   at SSHKeysManagement.list (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:141:19)
   at SSHKeysManagement.generateName (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:89:31)
   at SSHKeysManagement.migrate (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:45:22)
   at SSHKeysManagement.list (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:141:19)
   at SSHKeysManagement.generateName (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:89:31)
   at SSHKeysManagement.migrate (http://localhost:5173/src/utils/ssh.ts?t=1715176569964:45:22)
- Constructor: RangeError     show less
@Mahmoud-Emad Mahmoud-Emad added the type_bug Something isn't working label May 8, 2024
@Mahmoud-Emad Mahmoud-Emad moved this to Accepted in 3.14.x May 8, 2024
@Mahmoud-Emad Mahmoud-Emad added this to the 2.5.0 milestone May 8, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from Accepted to In Progress in 3.14.x May 8, 2024
@AlaaElattar AlaaElattar moved this from In Progress to Pending Review in 3.14.x May 9, 2024
@AlaaElattar AlaaElattar mentioned this issue May 9, 2024
5 tasks
@AlaaElattar AlaaElattar moved this from Pending Review to In Verification in 3.14.x May 9, 2024
@khaledyoussef24
Copy link
Contributor

how can we verify this?

@khaledyoussef24
Copy link
Contributor

the error are no longer produced and the deployment went smoothly , without any console errors.

Image
Image

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x May 21, 2024
@Mahmoud-Emad
Copy link
Contributor Author

how can we verify this?

in case you migrated your account.

  • Use an old version of the dashboard where we were supporting the old pattern of the SSH Key(The string one) and then navigate with the same account to the latest version of the dashboard, login, and go ahead to the FullVM page.

in case you have an old account that hasn't migrated yet, just log in and go ahead to the FullVM page.

@ramezsaeed ramezsaeed moved this from Done to In Verification in 3.14.x Jun 2, 2024
@khaledyoussef24
Copy link
Contributor

@Mahmoud-Emad I can not produce it now since all versions of the dashboard on all networks now works with manging ssh key.
it is verified that the issue is no longer produced not even on the qa version.
is it okay?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants