Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Grid Nightly workflow #3274

Merged
merged 28 commits into from
Aug 13, 2024
Merged

Fix Grid Nightly workflow #3274

merged 28 commits into from
Aug 13, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Aug 8, 2024 •
edited
Loading

Description

Refactor Grid Nightly workflow

Changes

  • Remove unnecessary steps
  • Add a set to check if same issue title exist
  • Remove old branch from all actions

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

zaelgohary added 24 commits August 7, 2024 13:22
@zaelgohary zaelgohary changed the title Development issue creation Fix Grid Nightly workflow Aug 8, 2024
@AhmedHanafy725
Copy link
Contributor

please squash merge this PR

Mahmoud-Emad
Mahmoud-Emad requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Zainab

.github/workflows/grid_client_nightly.yml Outdated Show resolved Hide resolved
.github/workflows/grid_client_nightly.yml Show resolved Hide resolved
.github/workflows/grid_client_nightly.yml Show resolved Hide resolved
@zaelgohary zaelgohary merged commit ce2ca59 into development Aug 13, 2024
9 checks passed
@zaelgohary zaelgohary deleted the development_issue_creation branch August 13, 2024 05:54
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @AhmedHanafy725 @Mahmoud-Emad @maayarosama @xmonader