Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new key word for new apps #3299

Merged
merged 25 commits into from
Sep 19, 2024
Merged

Add new key word for new apps #3299

merged 25 commits into from
Sep 19, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Aug 12, 2024 •
edited
Loading

Description

  • Add label with New for new applications.
  • Just update hasUpdate prop in the applications list to true and releaseDate to see changes.
  • Add badge for new updates in sidebar.

Changes

image
image

Test cases

image

  • return true if the releaseDate is within 30 days.
  • return false if the releaseDate was from more than 30 days.
  • return true if releaseDate is today.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel samaradel marked this pull request as ready for review August 26, 2024 13:12
@samaradel samaradel marked this pull request as draft August 27, 2024 10:16
@samaradel
- Update the sidebar with badge for new updates
ea39a2f 
- Check the day of appliction creation to determind when it will expire
@samaradel samaradel marked this pull request as ready for review August 27, 2024 15:22
Mahmoud-Emad
Mahmoud-Emad requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Samar

packages/playground/src/components/applications/ApplicationCards.vue Outdated Show resolved Hide resolved
packages/playground/src/views/solutions_view.vue Outdated Show resolved Hide resolved
zaelgohary
zaelgohary reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run the Dashboard multiple times but it lags on this page. I'm not sure why.

image

It happens only on this branch. I tried staging & different branches and they worked fine.

@samaradel samaradel marked this pull request as draft September 1, 2024 08:23
@samaradel samaradel marked this pull request as ready for review September 2, 2024 13:52
@samaradel samaradel marked this pull request as ready for review September 5, 2024 19:59
@amiraabouhadid
Copy link
Contributor

Please fix build error

@samaradel samaradel marked this pull request as draft September 18, 2024 09:17
@samaradel samaradel marked this pull request as ready for review September 18, 2024 12:24
@samaradel samaradel marked this pull request as draft September 19, 2024 11:47
@samaradel samaradel marked this pull request as ready for review September 19, 2024 14:25
@xmonader xmonader merged commit cc0b65f into development Sep 19, 2024
9 checks passed
@xmonader xmonader deleted the development_new_apps branch September 19, 2024 15:31
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
8 participants
@samaradel @MohamedElmdary @amiraabouhadid @xmonader @zaelgohary @Mahmoud-Emad @0oM4R @ehab-hassan