Fix: billing rate on first billing cycle #3490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-update GqlConsumption interface -initialize duration with 1 to avoid accessed before initialization error -avoid divide by zero by using the || operator
0oM4R
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
samaradel
as code owners
samaradel
approved these changes
Oct 2, 2024
Comment on lines
70
to
72
| nameContracts: GqlNameContract[]; | ||
| nodeContracts: GqlNodeContract[]; | ||
| rentContracts: GqlRentContract[]; |
There was a problem hiding this comment.
you can extend this interface instead GqlContracts
AhmedHanafy725
approved these changes
Oct 8, 2024
amiraabouhadid
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-update GqlConsumption interface
-initialize duration with 1 to avoid accessed before initialization error -avoid divide by zero by using the || operator
Description
the query response have each contract type separated while we are trying to access them indie contracts property
the solution is to access the contracts types directly
Changes
-update GqlConsumption interface
-initialize duration with 1 to avoid accessed before initialization error -avoid divide by zero by using the || operator
Related Issues
Tested Scenarios
get contract on its first billing cycle, and other with more than one billing report