Main rfs #2079
Main rfs #2079
Conversation
rawdaGastan
requested review from
muhamadazmy,
delandtj,
MarioBassem,
ashraffouda and
xmonader
as code owners
pkg/flist/mounts.go
Outdated
| @@ -12,6 +12,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| fsTypeRfs = "fuse.rfs" | |||
There was a problem hiding this comment.
this is not correct, this require a change to rfs actually because it still identity itself as g8ufs (that's something that is hard coded in the code) of course we can change that in rfs itself but I don't see why would we do that right now.
the idea was to be able to tell rfs from overlay so as long as we can do that it's fine. so in other words there should be no difference in reading the rfs from g8ufs since they both use the pid as source mount
pkg/flist/mounts.go
Outdated
| @@ -116,7 +117,7 @@ func (f *flistModule) resolve(path string) (g8ufsInfo, error) { | |||
| return g8ufsInfo{}, err | |||
| } | |||
|
|
|||
| if info.FSType == fsTypeG8ufs { | |||
| if info.FSType == fsTypeG8ufs || info.FSType == fsTypeRfs { | |||
There was a problem hiding this comment.
this means this is not deeded since both are defined as fuse.g8ufs
|
For testing the idea is that if u use
|
| sublog.Info().Strs("args", args).Msg("starting rfs daemon") | ||
| args = append([]string{"mount"}, append(args, mountpoint)...) | ||
| cmd = f.commander.Command("rfs", args...) | ||
| } |
There was a problem hiding this comment.
can we add an else case here so we return an error if the url extension is unknown
Issues